Todo List

Global __osGetId (OSPfs *pfs)

remove magic constant

loads of magic constants..

Global __osPfsReleasePages (OSPfs *pfs, __OSInode *inode, u8 start_page, u16 *sum, u8 bank, __OSInodeUnit *last_page, int flag)

magic number

Global __osPfsRWInode (OSPfs *pfs, __OSInode *inode, u8 flag, u8 bank)

don't like this =/ //maybe &inode->inode_table[j*PFS_ONE_PAGE].ipage or something

Global __osPiDevMgr

In libreultra this is in an include

Global __osRepairPackId (OSPfs *pfs, __OSPackId *badid, __OSPackId *newid)

fix magic number

remove magic constant

Global _course_mario_raceway_dl_mio0SegmentRomStart []

These should probably be ptr's instead of array's?

Global add_actor_to_empty_slot (Vec3f pos, Vec3s rot, Vec3f velocity, s16 actorType)

Commented out because deletes too soon.

Global are_players_in_course_section (s16, s16)

This is the easiest solution otherwise actors would not collide on custom courses.

Global ATrain::SyncComponents (TrainCarStuff *trainCar, s16 orientationY)

: Change actorIndex to ptr to TrainCar actor

Global BAD_RETURN (cmd)

put this define in types.h or similar. Certain functions are marked as having return values, but do not actually return a value. This causes undefined behavior, which we'd rather avoid on modern GCC. This only impacts -O2 and can matter for both the function itself and functions that call it.

Global clear_framebuffer (s32)

Why did void* work for matching

Global course_select_menu_act (struct Controller *, u16)

SetCourse() to course one;

Global D_800E43B0 []

unused?

Global debug_switch_character_ceremony_cutscene (void)

confirm this.

Union du

is it possible to remove them somehow?

is it possible to remove them somehow?

Global fill [2]

file boundary?

Global fill2

0x00000000800f624c fill2

Global freecam_keyboard_manager (Camera *, Vec3f)

configure this properly

Global func_80028864 (Player *, Camera *, s8, s8)

make a proper match

Global func_80046030 (u8 *tlut, u8 *texture, Vtx *arg2, s32 width, s32 arg4, s32 height)

tlut/texture unconfirmed. This could be texture1 and texture2

Global func_8004C268 (u32 arg0, u32 arg1, u8 *texture, u32 width, u32 arg4, u32 height, s32 arg6)

fakematch?

Global func_8004C268_wide (u32 arg0, u32 arg1, u8 *texture, u32 width, u32 arg4, u32 height, s32 arg6)

fakematch?

Global func_800745C8 (s32 objectIndex, const char **lakituTexturePtr)

arg1 should likely be a u8 *

Global func_80091FA4 (void)

These sizes need to be sizeof() for shiftability if possible

Global func_800CBC24 (void)

clenanup, something's weird with the variables. D_800EA4A4 is probably EuAudioCmd bc of the + 0x100

Global func_8028336C (UNUSED CinematicCamera *arg0, UNUSED Camera *camera)

Does this match as a return of s8?

Global func_802846E4 (CinematicCamera *)

What does this even do?

Global func_8028F970 (void)

increasing players past four would require increase this loop iterator.

Global GetCupName (void)

Move gGfxPool out of main.h

Global gPlayerWinningIndex

gPlayerWinningIndex (D_800DC5E8) accessed as word, D_800DC5EB as u8

Global gTorchSpawns []

fix this extern

Global IO_WRITE (addr, data)

These defines are from PR/rcp.h, but including that causes problems...

Global LEO_CMD_TYPE_0

name

Global LEO_CMD_TYPE_1

name

Global LEO_CMD_TYPE_2

name

Global load_track_path (s32)

Confirm this comment

Global logo_intro_menu_act (struct Controller *controller, UNUSED u16 controllerIdx)

Label audio funcs

Global MTX_KART_POOL_SIZE

Verify with proper documentation

Global MTX_SHADOW_POOL_SIZE

Verify with proper documentation

Global new_actor (ActorInitParams *)

More indepth error checking/return value

Global Note::priority

use macros or something instead.

Global OBombKart::Unk_3C

Turn WheelPos into a struct

Global osContInit (OSMesgQueue *mq, u8 *bitpattern, OSContStatus *status)

figure out what it means

Class OSeagull

unk_0D5 needs to be a struct variable probably. What does it do? Behaviour?

Global OSnowman::DrawBody (s32)

quick hack to add the snow particles on hit. Need to separate into its own class

Global OSnowman::Tick () override

quick hack to add the snow particles on hit. Need to separate into its own class

Global osPfsDeleteFile (OSPfs *pfs, u16 company_code, u32 game_code, u8 *game_name, u8 *ext_name)

magic constant

Global osPiStartDma (OSIoMesg *mb, s32 priority, s32 direction, uintptr_t devAddr, void *vAddr, size_t nbytes, OSMesgQueue *mq)

name magic constants

Global osRomBase

figure out why this is like this

Global osViBlack (u8 active)

name magic constants

Global osViSwapBuffer (void *vaddr)

figure out what this flag means

Class OThwomp

Make shadow size bigger if thwomp is scaled up

make adjustable properties for squishSize and boundingBoxSize

Global OThwomp::_boundingBoxSize

Write this better. This effects the squish size and the bounding box size.

Global PI_DOMAIN1

This define is from os.h, but including that causes problems...

Global render_collision (void)

decide to use colours or textures and fix displaylists because they are buggy

Global render_texture_rectangle (s32 x, s32 y, s32 width, s32 height, s32 s, s32 w, s32 mode)

Update to F3DEX. Uses OLD definition for gspTextureRectangle.

Global render_texture_rectangle_wide (s32 x, s32 y, s32 width, s32 height, s32 arg4, s32 arg5, s32 arg6)

Update to F3DEX. Uses OLD definition for gspTextureRectangle.

Global set_course (const char *data)

SetCourse();

Global set_minimap_finishline_position (s32)

: Hardcode these x and y values. Because why not?

Global SOUND_ARG_LOAD (sound_bank, byte2, byte3, sound_id)

format like sm64 sounds.h

Global spawn_foliage (struct ActorSpawnData *actor)

actorType needs to be passed into this function for flexibility

Global TrainSmokeTick (void)

: This should be an Object class one day

Global UPDATE_REG (reg, var)

This define is from piint.h, but including that causes problems...

Global US_FLOAT (x)

US_FLOAT should probably be renamed to JP_DOUBLE since eu seems to use floats too

Global World::SetCourse (const char *)

Use content dictionary instead